Modify Request Body for a GET request · spring-cloud/spring-cloud-gateway#1147

(7 留言) (0 反應) (0 負責人)Java (4,284 star) (3,204 fork)batch import

enhancementhelp wanted

描述

We currently have custom code for modifying request body which works but I want to move to the standard ModifyRequestBodyGatewayFilterFactory.

We have a scenario where Spring Cloud Gateway received a GET request and we need call an internal GraphQL api with a POST and a request body.

ModifyRequestBodyGatewayFilterFactory works great if there is a body present in the original request but doesn't apply the rewriteFunction when there is no body on GET requests.

I am using v2.1.2.RELEASE and I have hacked together a change to ModifyRequestBodyGatewayFilterFactory which works for me:

Mono<?> modifiedBody = serverRequest.bodyToMono(inClass)
        .defaultIfEmpty("") //added this line
        .flatMap(o -> config.rewriteFunction.apply(exchange, o));

I appreciate that the ModifyRequestBodyGatewayFilterFactory is beta, but would it be possible to support adding a body for GET requests in the future?

貢獻者指南

技術棧: javaspringgraphql
領域: backendapi
議題類型: feature
難度: 3
預計時間: half day
活動狀態: stale
清晰度: mostly clear
前置要求: JavaSpring Cloud GatewayReactive programming
新手友善度: 30
研究方向: Examine the current implementation of `ModifyRequestBodyGatewayFilterFactory` in the spring cloud gateway repository. The user's proposed fix is to add `.defaultIfEmpty("")` in the `filter` method to allow body rewriting when original request body is empty (typical for GET requests). Implement this change and ensure it does not break existing behavior for POST requests with a body. Write unit tests covering both scenarios and verify the filter works with the standard `ModifyRequestBodyGatewayFilterFactory`. Refer to the linked issue for additional context on the expected behavior.