spring-attic/spring-cloud-security

OAuth2 intercepter for feign does not re-issue invalid token

Open

#220 建立於 2019年9月2日

在 GitHub 查看
 (3 留言) (8 反應) (0 負責人)Java (525 star) (250 fork)batch import
enhancementhelp wanted

描述

Hi,

If we check OAuth2RestTemplate it has an option retryBadAccessTokens which will try one more time to obtain new access token if previous token is invalid. This is useful if, for some reasons, you decide to revoke access token.

In OAuth2FeignRequestInterceptor access token is preserved in client context until it expires. There is no way to make feign to reissue new token until it expire.

The difficulty here that in feign interceptor is not responsible for retry. So what will be correct way to handle this issue? One of the option is to implement a feign retryer which will clean up client context.

If it is correct, do you want me to try to contribute this change?

貢獻者指南

技術棧
javaspring
領域
backendapi
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Spring OAuth2 experienceFeign client usageJava knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The issue requests a retry mechanism for invalid OAuth2 tokens in Feign interceptors. The author suggests implementing a Feign Retryer to clean up the client context on token invalidation. To contribute, review the current OAuth2FeignRequestInterceptor and understand how tokens are stored. Consider adding a retryer that catches exceptions and refreshes the token. Since the repository is archived, check for any successor projects or note that the issue may need to be addressed in a different library.