sparklemotion/nokogiri

investigate #1970 - string optimization

Open

#1,986 建立於 2020年2月3日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)Ruby (5,615 star) (806 fork)batch import
help wantedneeds/researchtopic/performance

描述

Background

PR #1970 was opened by @ashmaroli to attempt to reduce the number of allocated empty strings created by Nokogiri.

This PR was merged and released in v1.11.0.rc1.

@ashmaroli repeated his profiling (I think using the memory_profiler gem) and commented that it didn't seem to have an effect.

Actions

  1. reproduce the original memory profliling scenario - @ashmaroli please help with this
  2. determine whether the patch can be tweaked to reduce the number of allocated strings or no
  3. make a recommendation - revert or re-patch

Retrospecting

I should have asked for more details from @ashmaroli when he submitted the PR to reproduce his results, and demonstrate improvement, before merging. This would have allowed me to ask questions at a more appropriate time.

貢獻者指南

技術棧
無
領域
performance
議題類型
research
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Rubymemory profiler gemnokogiri codebaseC extensions
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
25
研究方向
Reproduce the memory profiling scenario using the memory profiler gem as described in PR #1970. Review the patch in that PR and determine if it can be tweaked to reduce string allocations. The recommendation should be based on profiling results, either to revert or re patch. See comments from @ashmaroli in the PR for details.