slackapi/hubot-slack

Request: allow detecting when hubot-slack has disconnected and will not reconnect

Open

#536 建立於 2018年10月4日

在 GitHub 查看
 (7 留言) (2 反應) (0 負責人)CoffeeScript (2,339 star) (637 fork)batch import
auto-triage-skipenhancementgood first issue

描述

Description

While hubot-slack has support for reconnecting when the connection to Slack is lost, there is a limit to the number of reconnection attempts. If several reconnection attempts fail, the bot will simply hang without a connection. This causes trouble for our process manager, since the client staying open means we don't end up automatically restart it. When this has happened for us a few times lately, we had to manually notice and restart the service in order to get it back up.

I'd like to see some form of event be emitted in this condition to allow us to determine when this has happened so that we can terminate the process and let the process manager restart it.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

hubot-slack version: 4.5.5

node version: v8.2.0

OS version(s): Debian jessie

貢獻者指南

技術棧
nodejs
領域
backenddeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Node.js EventEmitter knowledgehubot slack codebase basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Examine the hubot slack source code, likely in files like `src/slack.coffee` or `src/client.coffee`, to locate the reconnection logic. Identify where reconnection attempts are counted and where they fail permanently. Then, add a new event emission (e.g., 'disconnected permanently') using Node.js EventEmitter pattern. Ensure the event includes relevant connection context. Test with a mock connection that fails repeatedly.