sindresorhus/update-notifier

Run in child process instead of lazy loading every dependency

Open

#210 建立於 2021年7月26日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)JavaScript (1,800 star) (164 fork)user submission
enhancementhelp wanted

描述

Not a big fan [of lazy loading], but I've seen update-notifier as a require time offender when profiling various things. The idea of update-notifier is that it should have no impact on the consumer. It's just an added bonus, not critical. https://github.com/yeoman/update-notifier/pull/82#issuecomment-225636213

I may be wrong, it seems to me that this change was made simply to hide the package from the very initial load but in practice every dependency is still loaded right after.

update-notifier already uses a child process to do the checking, so I think it'd be best to do the whole thing there.

Related:

貢獻者指南

技術棧
javascriptnodejs
領域
cliperformance
議題類型
performance
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Node.js child processesupdate notifier internals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Review the current implementation in index.js, especially the child process call at line 98. Understand how lazy loading currently works by examining the require statements. Then, design a solution where the entire update check logic runs in a child process, so dependencies are not loaded in the main process. Consider testing and edge cases.