Default `pkg` to the current package · sindresorhus/update-notifier#172

(5 留言) (2 反應) (0 負責人)JavaScript (1,800 star) (164 fork)user submission

enhancementhelp wanted

描述

The pkg option must be set with the package's package.json.

However this does not work well with ES imports. At the moment, importing JSON files with ES imports is still experimental in Node.js.

Also, hardcoding the path to package.json can be tricky when transpiling is involved. For example, my binary file is at src/bin.js, but it is transpiled to build/src/bin.js. If I want to run both files, I need to dynamically find the path to package.json with a library like read-pkg-up.

Adding an option to automatically find the package (with read-pkg-up for example) would solve this problem. This option would probably need user to pass __dirname to be able to find the right package.json.

What do you think?

I can submit a PR if needed.

貢獻者指南

技術棧: javascriptnodejs
領域: clideveloper experience
議題類型: feature
難度: 3
預計時間: 1-3 hours
活動狀態: stale
清晰度: clear
前置要求: Node.js basicsUnderstanding of update notifier's pkg option
新手友善度: 70
研究方向: Examine the `update notifier` source code to understand how the `pkg` option is currently read and used. Look at the main entry point (likely `index.js`) for the configuration logic. Then research the `read pkg up` library and consider how to integrate it to automatically locate the nearest `package.json`. The issue suggests passing ` dirname` as a parameter; evaluate this approach. Check the comments for any maintainer feedback to confirm the desired direction.