sindresorhus/update-notifier

Bad advice when using npx

Open

#112 建立於 2017年6月12日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (1,800 star) (164 fork)user submission
enhancementhelp wanted

描述

In this example, npx is using the locally-installed version of bower (node_modules/.bin/bower). update-notifier is correctly noticing that we're not using the latest version, but it suggests that npm i -g bower will fix that, which it will not, since it'll still use the locally-installed version, which is old.

pasted image at 2017_06_12 03_26 pm

=> $ npm -v
5.0.3
=> $ node -v
v6.9.5
=> $ npx -v
4.0.3

貢獻者指南

技術棧
javascriptnodejsshell
領域
clitooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic npm/npx knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate how update notifier determines whether a package is locally or globally installed. The issue occurs when npx is used, which runs a locally installed version but the notifier suggests a global update. Look at the source code in the repo to find the logic that checks for the installation path and where it generates the update message. Consider checking if the process is invoked via npx (e.g., environment variable or argv) and skip the global suggestion in that case.