sindresorhus/type-fest

`NonEmptyObject` fails for objects with dynamic properties

Open

#821 建立於 2024年2月27日

在 GitHub 查看
 (3 留言) (1 反應) (0 負責人)TypeScript (12,328 star) (471 fork)batch import
buggood first issuehelp wanted

描述

The following code is considered as valid by Typescript, although I was expecting it to complain that the filter foo in commonArguments was empty.

import type { NonEmptyObject } from "type-fest"

interface CommonArguments {
  [filter: string]: NonEmptyObject<{ [argument: string]: string | number | undefined }>
}

export const commonArguments: CommonArguments = {
  foo: {}
}

貢獻者指南

技術棧
typescript
領域
developer experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
understanding of TypeScript conditional typesfamiliarity with type fest utilities
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The issue is that the `NonEmptyObject` type does not correctly reject objects with index signatures when the object is empty. The problem lies in the type definition likely using a conditional type that checks if all keys are optional or similar. Investigate the current implementation in the source file (likely `source/non empty object.d.ts`). Consider adjusting the logic to handle index signatures by checking if the object has any known keys or if it is assignable to `Record<string, never>`. Review the TypeScript issue tracker for similar patterns. Look at linked PRs or comments for additional context.