sindresorhus/linkify-urls

Parentheses in URLs break linkifying

Open

#28 建立於 2017年11月7日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)JavaScript (173 star) (23 fork)user submission
bughelp wanted

描述

@fregante edit: Issue transferred from refined-github. This issue still happens in v3.1.0

See this line:

The URL contains parentheses which make the anchor cut off the URL in both the href and the visual link producing a wrong URL.

Original valid URL:

https://github.com/jserz/js_piece/blob/master/DOM/ParentNode/append()/append().md

貢獻者指南

技術棧
javascript
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic regex knowledgeJavaScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the current regex pattern used in the linkify urls library (likely in index.js) that fails to include parentheses in URLs. Look at the examples provided in the issue, such as 'https://github.com/jserz/js piece/blob/master/DOM/ParentNode/append()/append().md', to understand the failing case. The fix may involve modifying the regex to allow parentheses or escaping them properly. Check if any PRs or comments suggest a solution.
Parentheses in URLs break linkifying · sindresorhus/linkify-urls#28 | Good First Issue