sindresorhus/globals

Copy missing globals from `builtin` to `es*`

Open

#140 建立於 2018年8月28日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (587 star) (132 fork)user submission
enhancementhelp wanted

描述

While investigating why eslint wouldn't pick up the BigInt globals, I noticed eslint does not use builtin like I previously assumed. I'd like to propose to copy any globals missing in either es5, es2015, es2017 but present in builtin to one of those respective environments.

Afterwards, I'd copy back any potential globals from the es* categories to builtin so that it ends up containing all globals from those categories. Alternatively, builtincould be generated dynamically in index.js, I think actually, that'd be my preference to avoid future inconsistency.

貢獻者指南

技術棧
javascript
領域
tooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
JavaScript basicsKnowledge of ES5/ES2015/ES2017 globalsFamiliarity with the globals package structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
55
研究方向
First, examine the current globals definitions in the repository (likely in globals.json or similar files) to understand the structure of `builtin`, `es5`, `es2015`, and `es2017`. Compare the sets to identify missing globals. Then, review the issue comments for any proposed approaches, particularly the suggestion to generate `builtin` dynamically. The implementation could involve writing a script to copy and synchronize globals, ensuring consistency. Finally, consider testing the changes with ESLint to verify that globals like `BigInt` are correctly recognized.