sindresorhus/get-windows

Silently fails under Linux if xwininfo/xprop is missing

Open

#75 建立於 2020年7月10日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)JavaScript (913 star) (194 fork)user submission
enhancementhelp wanted

描述

Fails without further notice if xprop or xwininfo because they are either not installed, or not present in the PATH variable. If you ask me the promise should fail with a proper error when something fails (or throw an Error for the sync variant). The current behaviour makes debugging the root of the problem quite difficult.

https://github.com/sindresorhus/active-win/blob/430e6efc02823c1b04331a987012a519c360ab23/lib/linux.js#L109-L111

Also you might want to add that there is no Wayland support at the moment to the documentation especially considering the increasing popularity of Wayland.

I might PR this myself when I find the time.

貢獻者指南

技術棧
javascriptnodejs
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptNode.jsUnderstanding of Promises
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The issue points to a specific location in lib/linux.js (lines 109-111) where the promises fail silently when xwininfo or xprop are missing. The contributor should modify that code to catch errors during execution and reject the promise with a meaningful error message, or throw an Error for the synchronous variant. Additionally, consider updating the documentation to note the dependency on these tools and the lack of Wayland support. Testing on a Linux system without xwininfo and xprop will help verify the fix.