sindresorhus/execa

Attach `.nodeChildProcess` to the execa promise

Open

#413 建立於 2020年2月16日

在 GitHub 查看
 (13 留言) (1 反應) (0 負責人)JavaScript (6,091 star) (219 fork)batch import
enhancementhelp wanted

描述

Node.js does this now for childProcess. when you promisify it.

https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback

The name is to be decided.

One day, I hope we can get rid of execa() being both a childProcess and promise and just have the .child property on the promise. But that's a huge breaking change. For now, the best we can do is to add it, and recommend new users to use it instead of the old way. We could even un-document the old way.

@ehmicky Thoughts?

貢獻者指南

技術棧
javascriptnodejs
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Understanding of execa's promise APIFamiliarity with Node.js child process
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue proposes adding a `.nodeChildProcess` property to the execa promise, similar to Node.js child process. Key discussion points include naming and the gradual deprecation of the old dual behavior. Examine execa's source code in index.js and main.js to understand the current promise implementation. Review Node.js documentation for `child process.exec` callback. Consider the maintainer's comments (especially @ehmicky) for design decisions. The goal is to add the property without breaking changes, potentially marking the old approach as deprecated. Further reading: linked issue discussion and any related PRs.