sindresorhus/eslint-plugin-unicorn

consistent-function-scoping should ignore jest mocks

Open

#805 建立於 2020年8月4日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (5,022 star) (468 fork)user submission
enhancementhelp wanted

描述

Using jest.mock() does not work properly with consistent-function-scoping as it's not allowed to reference any out of scope variables as mocked function.

ReferenceError: /__tests__/search.spec.tsx: The module factory of `jest.mock()` is not allowed to reference any out-of-scope variables.

jest.mock("next/dynamic", () => () => "dynamic-drawer");

貢獻者指南

技術棧
javascripttypescript
領域
toolingtesting
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
understanding of ESLint plugin developmentfamiliarity with jest.mock()
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Locate the consistent function scoping rule implementation in rules/consistent function scoping.js. Understand how it checks for out of scope variables. The issue is that jest.mock factory functions are allowed to reference variables that are actually in scope (module level), but the rule incorrectly flags them. Look for where the rule evaluates function expressions or callbacks and add an exception for jest.mock() calls. Check existing tests for this rule to understand expected behavior.