sindresorhus/eslint-plugin-unicorn

no-fn-reference-in-iterator: Ignore locally declared functions?

Open

#717 建立於 2020年5月4日

在 GitHub 查看
 (8 留言) (2 反應) (0 負責人)JavaScript (5,022 star) (468 fork)user submission
enhancementhelp wanted

描述

I would like the following to be ignored by no-fn-reference-in-iterator:

const fn = item => {
  // do stuff with iterator items
};

iter1.forEach(fn);
iter2.forEach(fn);
iter3.forEach(fn);

Since fn is locally declared and defined the purpose of no-fn-reference-in-iterator does not apply. I see value in the following situations being reported:

const mapper = require('unicorn-mapper');

function doStuff(iter, fn) {
  iter.forEach(fn); // error on `fn` provided by argument
}

[2, 3, 4].forEach(mapper); // error as `mapper` is from a `require`

貢獻者指南

技術棧
javascriptnodejs
領域
developer experiencetooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ESLint plugin developmentAST traversalJavaScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the current implementation of the `no fn reference in iterator` rule in the repo (likely in `rules/no fn reference in iterator.js`). The rule currently flags all function references passed to iterators. Modify the AST visitor to check whether the function reference is a locally declared variable (e.g., a `const` or `let` declaration in the same scope) versus a parameter or imported function. Use scope analysis to distinguish. Add test cases covering both accepted and rejected patterns as provided in the issue.