sindresorhus/eslint-plugin-unicorn

Rule proposal: Enforce `.toArray()` at the end of `Iterator` methods chain

Open

#2,767 建立於 2025年9月25日

在 GitHub 查看
 (5 留言) (1 反應) (0 負責人)JavaScript (5,022 star) (468 fork)user submission
help wantednew rule

描述

Description

Note that it's a good idea to call toArray() as a last step of your processing. For example, fibonacci().take(10).toArray().filter(...) is less efficient, because iterator helpers are lazy and avoids creating a temporary array.

From https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator/toArray

Examples

// ❌
foo.toArray().filter(...)
//            ^^^^^^ Array#filter()

// ✅
foo.filter(...).toArray()
//  ^^^^^^ Iterator#filter()

Proposed rule name

not sure

Additional Info

No response

貢獻者指南

技術棧
javascript
領域
tooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Understanding of ESLint plugin architectureFamiliarity with AST (Abstract Syntax Tree)Basic knowledge of JavaScript iterators
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Review existing rule implementations in the plugin (e.g., 'prefer array flat map') as a reference. Examine the AST for calls like `foo.toArray().filter(...)` and determine how to detect when `.toArray()` is called before other array methods instead of after iterator methods. Consider using ESLint's `MemberExpression` and `CallExpression` nodes. The issue lacks a proposed rule name; comment to suggest a name based on naming conventions.