sindresorhus/eslint-plugin-unicorn

Rule proposal: Forbid `.splice(index, 1, element)` and `.splice(-1, 0, element)`

Open

#2,765 建立於 2025年9月25日

在 GitHub 查看
 (2 留言) (5 反應) (0 負責人)JavaScript (5,022 star) (468 fork)user submission
help wantednew rule

描述

Description

They are hard to read and confusing.

Examples

// ❌
array.splice(-1, 1, element);
array.splice(array.length - 1, 1, element); // This can be ignored since `unicorn/prefer-negative-index` already fix it to the previous one.

// ✅
array[array.length - 1] = element;

// ❌
array.splice(10, 1, element);

// ✅
array[10] = element;

// ❌
array.splice(-1, 0, element);

// ✅
array.push(element);

Proposed rule name

no-confusing-array-splice

Additional Info

I'm not sure about the rule name.

Note: the replacements in examples are not safe to fix, since they behavior differently when the index is out of boundary, even the -1 case, since the array can be empty.

貢獻者指南

技術棧
javascript
領域
developer experiencetooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
JavaScriptESLint plugin basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
The issue proposes a new ESLint rule `no confusing array splice` to forbid specific `.splice()` calls that can be replaced with simpler alternatives. To proceed, check the existing rule structure in the eslint plugin unicorn repository (e.g., rules directory) and discuss the rule name and scope with maintainers. The examples in the issue provide clear test cases.
Rule proposal: Forbid `.splice(index, 1, element)` and `.splice(-1, 0, element)` · sindresorhus/eslint-plugin-unicorn#2765 | Good First Issue