sindresorhus/eslint-plugin-unicorn

`require-module-attributes`: Support `TSImportType`

Open

#2,726 建立於 2025年9月1日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (5,022 star) (468 fork)user submission
change requestgood for beginnerhelp wanted

描述

Description

It seems typescript doesn't allow

type A = import("foo", {})

But allows

type A = import("foo", {with: {}})

I didn't add support for it in #2725, if someone need it, it can reuse the same logic as ImportExpression

Examples

// ❌
type A = import("foo", {with: {}})

// ✅
type A = import("foo")

Additional Info

No response

貢獻者指南

技術棧
typescriptjavascript
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
TypeScript AST knowledgeESLint rule developmentReading PR #2725
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Review the existing implementation of `require module attributes` rule and the changes made in PR #2725 for `ImportExpression`. The logic for handling `TSImportType` should mirror that of `ImportExpression` but adapted for type only imports. Focus on files like `rules/require module attributes.js` and look for how `ImportExpression` is handled. The issue provides clear examples of what should be flagged and what should be allowed.