sindresorhus/eslint-plugin-unicorn

`consistent-existence-index-check`: No rationale given for style

Open

#2,714 建立於 2025年8月6日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (5,022 star) (468 fork)user submission
docsgood for beginnerhelp wanted

描述

Description

This rule was introduced: https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1024, and our codebase uses the style: >= 0 and < 0 rather than !== -1 or === -1. Why this is preferred should either be documented, or a alternative style option could be provided.

Examples

This potential option would invert the typical behavior of the rule.

const index = foo.indexOf('bar');

// ❌
if (index === -1) {}


// ✅
if (index < 0) {}

const index = foo.indexOf('bar');

// ❌
if (index !== -1) {}

// ✅
if (index >= 0) {}

Additional Info

No response

貢獻者指南

技術棧
javascriptnodejs
領域
developer experiencedocumentation
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic JavaScriptESLint fundamentals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Review the implementation of the `consistent existence index check` rule in the plugin source code (likely `rules/consistent existence index check.js`). Examine the rationale behind the current style (`>= 0`/`< 0` vs `!== 1`/`=== 1`). Consider adding documentation to the rule's documentation or adding a new option to allow the alternative style. Check the referenced issue #1024 for prior discussion on the rationale.