sindresorhus/eslint-plugin-unicorn

`no-unnecessary-polyfills`: respect `.browserslistrc`

Open

#2,389 建立於 2024年6月24日

在 GitHub 查看
 (0 留言) (2 反應) (0 負責人)JavaScript (5,022 star) (468 fork)user submission
enhancementevaluatinghelp wanted

描述

Description

Currently it will respect a browserlist field in package.json but it would be great if it could also respect the .browserslistrc file.

This will be a little more complicated though as that file can define multiple targets, so an option as to which target to respect would also need to be added, defaulting to production.

Fail

# .browserslistrc

[production]
since 2024

[development]
last 1 version

if (!("groupBy" in Object)) {
  import("object.groupby").then(({ shim }) => shim())
}

Pass

# .browserslistrc

[production]
since 2020

[development]
last 1 version

if (!("groupBy" in Object)) {
  import("object.groupby").then(({ shim }) => shim())
}

Additional Info

No response

貢獻者指南

技術棧
javascriptnodejs
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Basic understanding of ESLint pluginsFamiliarity with browserslistWorking knowledge of Node.js file system
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the current implementation of browserslist support in the plugin, likely in the `no unnecessary polyfills` rule. Look for how the `browserslist` field from `package.json` is read and used. Then implement parsing of `.browserslistrc` file, which can have multiple sections. Add a new option (e.g., `browserslistTarget`) defaulting to `production`. Ensure to use the `browserslist` package's API for parsing configuration. Consider integrating with existing logic to merge options. No PR linked; the issue has no comments.
`no-unnecessary-polyfills`: respect `.browserslistrc` · sindresorhus/eslint-plugin-unicorn#2389 | Good First Issue