Improve `prefer-dom-node-remove` · sindresorhus/eslint-plugin-unicorn#2085

2023-05-09T08:57:39.000Z

- [x] Use snapshot test https://github.com/sindresorhus/eslint-plugin-unicorn/pull/2333 - [ ] Improve fix, not use the original text but manipulate tokens - [ ] Improve fix for `node?.parentNode.removeChild(node)` (node can be anything, the object and the argument should be same reference, but can be different AST, eg: `a?.b?.parentNode.remove(a.b)`)

(0 留言) (0 反應) (0 負責人)JavaScript (5,022 star) (468 fork)user submission

enhancementhelp wanted

描述

Use snapshot test https://github.com/sindresorhus/eslint-plugin-unicorn/pull/2333
Improve fix, not use the original text but manipulate tokens
Improve fix for node?.parentNode.removeChild(node) (node can be anything, the object and the argument should be same reference, but can be different AST, eg: a?.b?.parentNode.remove(a.b))

貢獻者指南

技術棧: javascriptnodejs
領域: developer experiencetooling
議題類型: refactor
難度: 3
預計時間: 1-3 hours
活動狀態: fresh
清晰度: mostly clear
前置要求: Experience with ESLint rulesUnderstanding of ASTFamiliarity with fixer API
新手友善度: 50
研究方向: Examine the existing fixer in `rules/prefer dom node remove.js` (likely in the repository). Review the merged PR #2333 for snapshot test style. For the second task, replace the use of original text with token manipulation by accessing AST tokens via `sourceCode.getTokens()` or similar. For the third task, handle optional chaining (e.g., `node?.parentNode.removeChild(node)`) ensuring the same reference is used in both the object and argument; consider using `sourceCode.getText()` or comparing AST nodes. Look at existing tests in `test/snapshots/prefer dom node remove.md` for guidance.