sindresorhus/element-ready

Use types directly from querySelector, without copying them

Open

#32 建立於 2020年12月29日

在 GitHub 查看
 (0 留言) (2 反應) (0 負責人)JavaScript (447 star) (17 fork)user submission
enhancementhelp wanted

描述

If the selector is 'a', querySelector‘s return type is be HTMLAnchorElement. To achieve the same in element-ready, we had to manually copy its types and adapt them to elementReady

Ideally, instead, we should try to “inherit” directly from the global querySelector so that, if its types are enhanced (via typed-query-selector or natively), element-ready automatically gets upgraded.

Note: We can't use Parameters<typeof querySelector> and such because it doesn't support overloads nor generics.

This has been unsuccessfully tried in #31. More info about it in that PR. A possible solution might be https://github.com/microsoft/TypeScript/issues/33185#issuecomment-526969274

貢獻者指南

技術棧
typescriptjavascript
領域
developer experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
TypeScript genericsUnderstanding of querySelector types
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Review the previous attempt in PR #31 to understand why it failed. Explore the suggested solution from the TypeScript issue comment (microsoft/TypeScript#33185). Investigate if 'typed query selector' can be integrated or if native TypeScript improvements (issue #29037) can be leveraged. Look at the current type definitions in the element ready package to see how types are copied and how they could be inherited from global querySelector.