sindresorhus/electron-unhandled

Add a filter option

Open

#18 建立於 2020年4月1日

在 GitHub 查看
 (7 留言) (7 反應) (0 負責人)JavaScript (464 star) (27 fork)user submission
enhancementhelp wanted

描述

It would be great if we had a configurable filter function that, if defined in the options, gets called BEFORE the options.logger and showMessageBox function get called and returns true or false to decide if the error should pass or not.

That way one could filter out error messages like ERR_CONNECTION_REFUSED that are not catchable

貢獻者指南

技術棧
javascriptnodejselectron
領域
desktop
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of ElectronUnderstanding of error handling in JavaScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
The issue requests a filter option in the electron unhandled library. The implementation would involve adding a `filter` function to the options object that receives the error and returns a boolean. The main handler in the library should check the filter before calling `options.logger` and `showMessageBox`. Relevant code is likely in the main module file, possibly `index.js` or `unhandled.js`. The maintainer has not provided further guidance, so contributors should review the existing codebase for pattern of option handling.