sindresorhus/electron-dl

Enable an app to display a custom "interrupted" dialog

Open

#105 建立於 2020年2月13日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (1,206 star) (136 fork)user submission
enhancementhelp wanted

描述

Rather than just allowing the 'The download of {filename} was interrupted' system message box text to be customized, enable the app to provide a dialog box styled per the app.

Could perhaps be achieved by one of: (a) Add an 'onError' optional callback. (No "interrupted" dialog is displayed is this callback is specified.) (b) Allow a blank string to be specified as the value of 'errorMessage'. (No "interrupted" dialog is displayed if the string is ""; the "interrupted" result can be found by testing the 'state' returned by the 'done' event).

貢獻者指南

技術棧
javascriptnodejs
領域
desktop
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic JavaScriptElectron framework knowledgeUnderstanding of callbacks
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Investigate the current implementation of download error handling in electron dl. Look at the codebase to understand how the app currently displays the 'interrupted' dialog. Consider implementing option (a): adding an optional 'onError' callback that overrides the default dialog. Alternatively, option (b): allowing an empty errorMessage string to suppress the dialog and let the app handle the state. Check existing tests and documentation for guidance. Discuss with maintainers if needed.