sindresorhus/electron-context-menu

Omitting default actions if already provided

Open

#70 建立於 2019年5月9日

在 GitHub 查看
 (7 留言) (0 反應) (0 負責人)JavaScript (1,471 star) (167 fork)user submission
enhancementhelp wanted

描述

I'm defining a custom "Copy" action, which does something a bit different than the default "Copy" action, to some buttons, but on right click the content of the button gets selected (and I can't make them unselectable) and so the menu displays 2 "Copy" actions, the one I defined and the one this library defines:

I think I could generate the whole menu manually via the menu option but that would mean detecting all the cases where the default actions should be showed.

Could we instead add an option, canOverrideDefaultActions or something, where before inserting each default action the library check if another action with the same label has been provided already?

貢獻者指南

技術棧
javascriptelectron
領域
desktopfrontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptElectron
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the source code (likely `index.js`) where default actions are defined and inserted into the context menu. Check for any existing mechanism to detect duplicate labels. The issue discussion may contain further suggestions from the maintainer. Consider adding an option like `canOverrideDefaultActions` that checks for existing custom actions with the same label before adding defaults.