sindresorhus/del

Async throw error delay

Open

#98 建立於 2019年7月12日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (1,305 star) (71 fork)batch import
enhancementhelp wanted

描述

Would you accept a PR that would change how async errors are thrown so the error is thrown after all pending files being deleted are removed? This would help deal with side effects a lot cleaner, especially when testing.

Similar to https://github.com/sindresorhus/del/pull/90.

貢獻者指南

技術棧
javascriptnodejs
領域
tooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Node.js async/awaiterror handling patterns
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the existing error handling in the del library, focusing on the async file deletion logic. Review linked PR #90 for a similar approach. Test how errors are currently thrown during pending deletions and propose a change to defer the error until all deletions complete.