sindresorhus/Plash

After macOS waking up without internet connection, no website is shown

Open

#41 建立於 2020年2月4日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人) (3,961 star) (157 fork)user submission
bughelp wanted

描述

Describe the bug

I'm working on different setups where one has internet through WLAN and the other over LAN. When switching workplaces (opening/closing the lid) it seems Plash can not reload the web page or get back to the last state.

To reproduce

Steps to reproduce the behavior:

  1. Open any website
  2. Turn off w-lan
  3. Close the lid
  4. Open the lid
  5. red Plash icon
  6. no website

Expected behavior

Saving the last state and waiting for a new internet connection or use a service worker to save the site offline.

Screenshots

If applicable, add screenshots to help explain your problem.

Info

  • macOS version: 10.15.2
  • Plash version: latest (don't know where I can see this, mabye add the version and hash as read only menu item)

Additional context

Add any other context about the problem here.

貢獻者指南

技術棧
swift
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
macOS development experienceSwift knowledgeWebKit basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate how Plash handles network state changes when waking from sleep. Look at the WKWebView usage in the source code (likely in Swift) and check if there's a mechanism to reload or cache the page. Consider adding network reachability monitoring and reloading the web view when network becomes available. Also explore using `WKWebsiteDataStore` for caching or implementing a service worker if the website supports it. Refer to Apple's documentation on handling network transitions.