simonw/datasette

sql-formatter javascript is not now working with CloudFlare rocketloader

Open

#1,969 建立於 2022年12月23日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Python (8,637 star) (625 fork)batch import
bughelp wantedjavascript

描述

This is probably not a bug with datasette, but I thought you might want to know, @simonw.

I noticed today that my CloudFlare proxied datasette instance lost the "Format SQL" option. I'm pretty sure it was there last week.

In the CloudFlare settings, if I turn off Rocket Loader, I get the "Format SQL" option back.

Rocket Loader works by asynchronously loading the javascript, so maybe there was a recent change that doesn't play well with the asynch loading?

I'm up to date with https://github.com/simonw/datasette/commit/e03aed00026cc2e59c09ca41f69a247e1a85cc89

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic JavaScriptKnowledge of CloudFlare Rocket Loader
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate how the JavaScript for the SQL formatter is loaded in datasette. Look at the relevant commit e03aed00026cc2e59c09ca41f69a247e1a85cc89 to see if any changes were made to script loading. Check if the script has an 'async' or 'defer' attribute or if it is loaded via a dynamic import that conflicts with Rocket Loader. Consider adding a script attribute or ensuring the script loads synchronously when Rocket Loader is active.
sql-formatter javascript is not now working with CloudFlare rocketloader · simonw/datasette#1969 | Good First Issue