simonw/datasette

Get rid of this `restore_working_directory` hack entirely

Open

#1,366 建立於 2021年6月7日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Python (8,637 star) (625 fork)batch import
help wantedrefactortests

描述

That seems to have fixed it. I'd love to get rid of this restore_working_directory hack entirely.

Originally posted by @simonw in https://github.com/simonw/datasette/issues/1361#issuecomment-855308811

貢獻者指南

技術棧
python
領域
backend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
PythonDatasette internals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Examine the codebase for uses of `restore working directory` by searching the repository. Understand the hack's purpose by reading the linked comment in issue #1361. Determine if it can be replaced with a cleaner pattern, such as using context managers or temporary directory changes. Consider testing the change to ensure no regressions.