sharkdp/hyperfine

Excluding non-zero exit codes from Relative Time comparison.

Open

#591 建立於 2022年12月2日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)Rust (28,110 star) (479 fork)batch import
feature-requesthelp wanted

描述

I usually run a few sets of parameter lists which quickly explodes in number of instances (which is working as intended!). However, all the runs are shown in the summary at the end including those that exited with an non-zero exit code.

Looking at the code base, adding a filter in src/benchmark/relative_speed::compute to remove results with non-zero exit codes from the output should fix it.

I'm not really sure if there are more dependencies on the compute function elsewhere though or I would have just pushed a PR.

PS. Thanks for the all the great software! I use hyperfine, fd, and bat all the time!

貢獻者指南

技術棧
rust
領域
cliperformance
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rusthyperfine codebase structurerelative speed module
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue proposes adding a filter in `src/benchmark/relative speed.rs` at the `compute` function to exclude results with non zero exit codes. The contributor should examine the `compute` function to understand how results are aggregated and how to filter out entries where the exit code is non zero. Check for any other callers of `compute` that might be affected, as mentioned in the issue. The implementation should be straightforward and localized to that function.