sharkdp/fd

Design and refactoring / general code quality

開放

#382 建立於 2019年1月4日

 (15 則留言) (1 個反應) (0 位負責人)Rust (1,059 個分叉)batch import
good first issuehelp wanted

倉庫指標

星標
 (42,984 顆星)
PR 合併指標
 (平均合併 15天 23小時) (30 天內合併 16 個 PR)

描述

This is intended as a tracking issue for general code quality and design discussions. @sharkdp feel free to close this when you think quality has reached an overall satisfactory level.

To start, I'll quote a recent comment by @sharkdp from a discussion on a PR thread:

There are many things I have in mind that would hopefully help to improve the code quality:

  • Group related functions into impl blocks of appropriate structs such that we don't have to pass around so many parameters.
  • Think about a unified interface for filters (file type, file size, modification data, file extension, ..). Maybe a trait-based interface where the filters would be stored in a Vec<Box<dyn Filter>>.
  • Extract some of the functionality like the OsStr-based path handling into separate libraries / crates.

貢獻者指南