serverless-nextjs/serverless-next.js

`originUrl.includes("s3")` produces false positives

Open

#761 建立於 2020年11月3日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (3,998 star) (447 fork)batch import
buggood first issue

描述

Describe the bug

Hi there! 👋

I'm adding an origin of this form http://foo.s3-website-eu-west-1.amazonaws.com.

As other issues revealed those kind of origins are not an S3OriginConfig but a CustomOriginConfig.

So it might help to exclude these kind of origins, or maybe allow setting an extra flag to to mark an origin as non-S3OriginConfig.

here's the problematic line of code: https://github.com/serverless-nextjs/serverless-next.js/blob/e7b5c1d302eef1daf32d150e0f12f94d4311eb0a/packages/serverless-components/aws-cloudfront/lib/getOriginConfig.js#L18

貢獻者指南

技術棧
typescriptnodejsaws
領域
cloudinfrastructuredevops
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic TypeScriptAWS CloudFront origin config concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
Look at the referenced line in packages/serverless components/aws cloudfront/lib/getOriginConfig.js line 18. The condition `originUrl.includes('s3')` falsely identifies S3 website endpoints as S3 origins. Research the difference between S3OriginConfig and CustomOriginConfig in AWS CloudFront, and find a more robust way to distinguish them, such as checking domain patterns or using the AWS SDK's origin type detection.