serverless-nextjs/serverless-next.js
在 GitHub 查看`originUrl.includes("s3")` produces false positives
Open
#761 建立於 2020年11月3日
buggood first issue
倉庫指標
- Star
- (3,998 star)
- PR 合併指標
- (30 天內沒有已合併 PR)
描述
Describe the bug
Hi there! 👋
I'm adding an origin of this form http://foo.s3-website-eu-west-1.amazonaws.com.
As other issues revealed those kind of origins are not an S3OriginConfig but a CustomOriginConfig.
So it might help to exclude these kind of origins, or maybe allow setting an extra flag to to mark an origin as non-S3OriginConfig.
here's the problematic line of code: https://github.com/serverless-nextjs/serverless-next.js/blob/e7b5c1d302eef1daf32d150e0f12f94d4311eb0a/packages/serverless-components/aws-cloudfront/lib/getOriginConfig.js#L18