schickling/chromeless

Pass chromePath and chromeFlags in Chromeless options to chrome-launcher

Open

#184 建立於 2017年8月6日

在 GitHub 查看
 (0 留言) (4 反應) (0 負責人)TypeScript (13,240 star) (606 fork)batch import
APIfeaturehelp wanted

描述

Add chromePath and chromeFlags to ChromelessOptions which get passed to the chrome-launcher's constructor so that users can specify a path to their Chrome installation and provide custom flags.

Brought up in https://github.com/graphcool/chromeless/issues/158#issuecomment-320455862

貢獻者指南

技術棧
typescriptnodejs
領域
testingbackend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic TypeScript knowledgeFamiliarity with chrome launcher
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The issue requests adding `chromePath` and `chromeFlags` to `ChromelessOptions` and passing them to the `chrome launcher` constructor. Look at the current `ChromelessOptions` type definition (likely in `src/index.ts` or similar) and the section where `chrome launcher` is instantiated (e.g., `src/chromeless.ts`). Check the referenced issue #158 for context. Implement by extending the options interface and modifying the `chrome launcher` call to pass the new properties. Ensure TypeScript types are updated accordingly.