scalameta/metals

Clean constructor parameters for `Indexer` and `ScalaCli`

Open

#4,788 建立於 2023年1月1日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)Scala (2,300 star) (421 fork)batch import
good first issueimprovementtech debt

描述

Another follow up after https://github.com/scalameta/metals/pull/4776.

There's need to pass every constructor argument as a function in scala.meta.internal.metals.Indexer and scala.meta.internals.ScalaCli

  • Usually, replacing () =>, should be straighforward change, but sometimes () => was used to capture mutable state.
  • probably Indexerand ScalaCli aren't the only ones which can be refactored. Person doing this task can browse other classes (optional)

貢獻者指南

技術棧
scala
領域
backend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Scala programmingFamiliarity with Metals internalsUnderstanding of mutable state patterns
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the constructor parameters of Indexer and ScalaCli classes in scala.meta.internal.metals package. Identify which () => parameters can be replaced with direct values and which are capturing mutable state. For the latter, ensure the refactoring preserves correctness. Optionally, extend the refactoring to other similar classes in the codebase.