Clean constructor parameters for `Indexer` and `ScalaCli`

Another follow up after https://github.com/scalameta/metals/pull/4776.

There's need to pass every constructor argument as a function in scala.meta.internal.metals.Indexer and scala.meta.internals.ScalaCli

• Usually, replacing () =>, should be straighforward change, but sometimes () => was used to capture mutable state.
• probably Indexerand ScalaCli aren't the only ones which can be refactored. Person doing this task can browse other classes (optional)