sbt/sbt-native-packager

Sbt-native-packager doesn't follow folders symlinks during packageZipTarball

Open

#1,134 建立於 2018年6月19日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Scala (1,593 star) (439 fork)batch import
bughelp wanteduniversal

描述

Hi! I have an universal folder in resources that contains conf folder:

└── universal
    ├── conf
    │   ├── akka.conf -> ../../main/resources/akka.conf
    │   ├── common.conf -> ../../main/resources/common.conf
    │   ├── local -> ../../main/resources/local/
    │   ├── logback-appenders.xml -> ../../main/resources/logback-appenders.xml
    │   ├── mailer.conf -> ../../main/resources/mailer.conf
    │   ├── mongo.conf -> ../../main/resources/mongo.conf
    │   ├── production -> ../../main/resources/production/
    │   ├── spray.conf -> ../../main/resources/spray.conf
    │   └── staging -> ../../main/resources/staging/
    └── start.sh

As you can see, the most of the files are just symlinks to other place. The problem is that when I build package, all files are copied, but folders are copied without their content (not recursively). So in final build I have something like that:

├── conf
│   ├── akka.conf
│   ├── common.conf
│   ├── local <-- empty!
│   ├── logback-appenders.xml
│   ├── mailer.conf
│   ├── mongo.conf
│   ├── production <-- empty!
│   ├── spray.conf
│   └── staging <-- empty!

If I have simple folders (not a symlink) it works fine. So seems like it doesn't follow symlinks till the end.

Expected behaviour

universal:packageZipTarball should copy all reachable files recursively (including symlinks)

Actual behaviour

universal:packageZipTarball copies symlink as an empty directory

Information

  • What sbt-native-packager are you using: 1.3.5
  • What sbt version: 1.1.6
  • What is your build system (e.g. Ubuntu, MacOS, Windows, Debian ): MacOS 10.13.5
  • What package are you building (e.g. docker, rpm, ...): tar
  • What version has your build tool (find out with e.g. rpm --version): bsdtar 2.8.3 - libarchive 2.8.3

貢獻者指南

技術棧
scala
領域
build system
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Scalasbt
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
Investigate how sbt native packager handles symlinks during file packaging. The issue describes that symlink directories are copied as empty directories instead of following the symlink. Look into the code for packaging tasks, such as packageZipTarball, and examine how files are copied (likely using sbt IO utilities). Check the existing comments on the issue for any suggested approaches or related PRs. Consider using Java's Files#isSymbolicLink or similar to follow symlinks.
Sbt-native-packager doesn't follow folders symlinks during packageZipTarball · sbt/sbt-native-packager#1134 | Good First Issue