sandstorm-io/sandstorm

Demo tests in `tests/basic.js` are broken.

Open

#3,615 建立於 2022年4月10日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (6,583 star) (737 fork)batch import
good first issuesandstorm-dev

描述

I noticed when picking through the test suite there is logic to explicitly disable demo related tests in tests/basic.js, apparently because at some point they were blocking release and considered not critical.

We should actually fix those eventually.

貢獻者指南

技術棧
javascript
領域
testing
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Familiarity with tests/basic.jsAbility to reproduce test failures
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Start by examining tests/basic.js to identify which demo tests are disabled and the logic that disables them. Run the test suite to observe the failures. Look at the git history for any previous attempts or discussions. Then propose a plan to fix the failing demo tests.