[Improvement] use BEM in a proper way and make plyr CSS more modular. · sampotts/plyr#567

(7 留言) (1 反應) (1 負責人)JavaScript (25,318 star) (2,856 fork)batch import

Help WantedImprovement

描述

Hey,

It's great that you try to use the BEM methodology in your CSS. But your CSS is not fully compatible with BEM. You use BEM syntax (-- for modifiers and __ for elements) which is good, but there is a lot of nested selectors which is against BEM rules.

For example:

.plyr__controls {
    display: flex;
    align-items: center;
    line-height: 1;
    text-align: center;

    // Spacing
    > button,
    .plyr__progress {
    // ... code
   }
}

This it not a valid BEM syntax.

Because of this sometimes overwriting your styles is problematic - one have to deal with specificity issues.

Istead of nesting you should break your styles into smaller modules. Here's a great article on how to deal with common BEM problems: https://medium.com/fed-or-dead/battling-bem-5-common-problems-and-how-to-avoid-them-5bbd23dee319

貢獻者指南

技術棧: cssjavascript
領域: frontend
議題類型: refactor
難度: 3
預計時間: 1-2 days
活動狀態: stale
清晰度: clear
前置要求: Understanding of BEM methodologyCSS specificity knowledgeFamiliarity with plyr CSS structure
新手友善度: 45
研究方向: The issue requests refactoring the plyr CSS to follow BEM methodology properly by removing nested selectors. Currently, the CSS uses nesting that increases specificity. To address this, audit the CSS files (likely under src/css/) and convert nested rules into separate BEM modifier/element classes. For example, replace `.plyr controls > button, .plyr controls .plyr progress` with standalone `.plyr controls` and then use modifiers like `.plyr controls button` if needed. The linked Medium article provides guidance on common BEM pitfalls. Since there is an assignee but no open PR, communication with the maintainer about the current status may be needed before starting.