saadq/resumake.io

Source code display doesn't work on iOS... or maybe it does, but doesn't signal type to user?

Open

#12 建立於 2017年6月2日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)TeX (3,559 star) (485 fork)batch import
bughelp wanted

描述

It looks like you're providing binary data of some kind in response to the generate source button. In mobile safari, I get a binary file with a URL like blob:https://latexresu.me/a833e5be-1f05-46b5-b1c6-b445d5ad6082 --- shouldn't it just be a plain text .tex file?

Actually, poking around, I see that the very last commit just set that to application/zip. That wasn't clear to me from the interface---is source code download multiple files? Maybe it would be helpful to send the user a signal that they should be downloading a zip, like give it a filename or something?

貢獻者指南

技術棧
javascriptnodejs
領域
frontendbackend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic HTTP headersJavaScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the source code download endpoint in the backend (likely Node.js/Express). The last commit (8c4bfdd) changed the Content Type to application/zip. Determine if the response should be a plain text .tex file or a zip of multiple files. Consider setting proper Content Disposition header to signal download type on iOS Safari. Look at the route handling '/api/source' or similar in the codebase.