rwf2/Rocket

Allow wildcards in content-type

Open

#583 建立於 2018年3月11日

在 GitHub 查看
 (6 留言) (5 反應) (0 負責人)Rust (25,738 star) (1,645 fork)batch import
enhancementgood first issue

描述

Currently (Rocket version 0.4.0-dev) if you use a wildcard in content-type you will get a warning like this:

warning: 'image/*' is not a known media type
 --> src/handlers/image.rs:5:33
  |
5 | #[post("/image", format = "image/*", data = "<data>")]
  |                                 ^^^^^^^^^

Using wildcard e.g. for images is needed as you do not know what the actual type of the image will be (png, gif, jpg etc.) and you want to handle all of them in the same route.

貢獻者指南

技術棧
rust
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rust programmingRocket framework basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate how Rocket currently parses and validates media types in the 'format' route attribute. The warning originates from a media type parser that rejects wildcards. Look at the 'rocket codegen' crate's 'format' parsing logic and the 'http' crate's 'MediaType' implementation. Consider proposing a change to allow wildcards by accepting known top level types (e.g., 'image') with any subtype. Check issue comments for prior discussion and any maintainer suggestions.
Allow wildcards in content-type · rwf2/Rocket#583 | Good First Issue