rwf2/Rocket

Phase out async_trait macro

Open

#2,684 建立於 2023年12月30日

在 GitHub 查看
 (5 留言) (6 反應) (0 負責人)Rust (25,738 star) (1,645 fork)batch import
acceptedhelp wantedrequest

描述

What's missing?

Rocket currently re-exports the async_trait crate for use with its Fairing (and possibly others). As of rust 1.75.0 this is no longer needed, therefore it would be nice to get rid of this dependency and use actual async functions for these traits.

This generally improves compile times, dependency count and IDE responsiveness.

Ideal Solution

For v0.6, remove async_trait (or put its usage behind a feature) and use async functions directly. This would raise the MSRV to 1.75.0.

Why can't this be implemented outside of Rocket?

This is an integral part of Rocket.

Are there workarounds usable today?

No. You bypass the need for the macro attribute by returning a Box<dyn Future<Output = T> + Send + 'a>, but this is unwieldy.

Alternative Solutions

No response

Additional Context

No response

System Checks

  • I do not believe that this feature can or should be implemented outside of Rocket.
  • I was unable to find a previous request for this feature.

貢獻者指南

技術棧
rust
領域
backend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rust knowledgeAsync programming in RustFamiliarity with Rocket's Fairing trait
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Look for all usages of `async trait` in the Rocket codebase, particularly in the `Fairing` trait and any other traits that currently use the `#[async trait]` attribute. Check the `Cargo.toml` for the `async trait` dependency and its feature flags. The goal is to replace each `#[async trait]` attribute with `async fn` in trait definitions and implementations, and remove the dependency. Consider raising the MSRV to 1.75.0 as mentioned.
Phase out async_trait macro · rwf2/Rocket#2684 | Good First Issue