rust-lang/this-week-in-rust

Email publishing codegen script is not formatting correctly

Open

#3,591 建立於 2022年8月26日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)HTML (1,932 star) (1,010 fork)batch import
bughelp wanted

描述

The Pelican publishing script used by the Makefile command optimize-email is not picking up TWIR_NEWSLETTER_THEME setting and defaulting to a CSS style that does not match our most recent issues (e.g. 454).

Currently, the workaround for this has been to change pelicanconf.py from:

if '1' == os.environ.get('TWIR_NEWSLETTER_THEME'):
    THEME = 'themes/newsletter'
else:
    THEME = 'themes/rusted'

to:

THEME = 'themes/newsletter'

貢獻者指南

技術棧
pythonhtmlcssshell
領域
content
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue is in the This Week in Rust repository, specifically in pelicanconf.py where the environment variable TWIR NEWSLETTER THEME is checked. The fix involves ensuring the script correctly picks up the theme setting when generating the email. The current workaround of directly setting the theme to 'themes/newsletter' suggests a simple code change to read the environment variable properly and apply the correct theme. No linked PRs or maintainer questions were found.