rust-lang/rustfmt

PreferSameLine brace_style with trailing_comma Vertical produces weird results

Open

#2,321 建立於 2017年12月30日

在 GitHub 查看
 (3 留言) (0 反應) (1 負責人)Rust (4,893 star) (760 fork)batch import
I-poor-formattinggood first issueonly-with-option

描述

Upgrading rustfmt-nightly from 0.2.15 to 0.3.4 created this change:

@@ -104,8 +122,7 @@ impl FetchCommandMessages {
 
 pub trait FetchBuilderMessages
 where
-    Self: Sized,
-{
+    Self: Sized, {
     fn prepare(self) -> FetchCommandMessages;
 
     fn num(self, num: u32) -> FetchCommandMessages {

This seems like a bug, since trailing_comma = "Vertical" should not trigger if the opening brace is on the same line.

貢獻者指南

技術棧
rust
領域
toolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rust programmingunderstanding of rustfmt configuration options
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the interaction between `brace style = "PreferSameLine"` and `trailing comma = "Vertical"` in rustfmt. The bug shows that when the opening brace is on the same line as the trait declaration, a trailing comma is incorrectly added. Examine the source code for formatting traits and functions, likely in files related to brace placement and trailing comma logic. Check if the assignee (gentoid) has any progress or comments on the issue.