improve collapsible if in complex cases with same expressions · rust-lang/rust-clippy#812

2016-03-30T14:34:06.000Z

``` rust if a { if b { f(); } } else { f(); } ``` could be ``` rust if !a || b { f(); } ```

(1 留言) (0 反應) (1 負責人)Rust (10,406 star) (1,391 fork)batch import

A-lintC-enhancementgood first issue

描述

if a {
    if b {
        f();
    }
} else {
    f();
}

could be

if !a || b {
    f();
}

技術棧: rust
領域: toolingdeveloper experience
議題類型: feature
難度: 3
預計時間: 1-2 days
活動狀態: stale
清晰度: clear
前置要求: RustClippy internalsAST knowledgeLogical expressions
新手友善度: 45
研究方向: Examine the current implementation of the collapsible if lint in rust clippy (file clippy lints/src/collapsible if.rs). Understand how it currently detects simple nested if statements. The enhancement would require adding logic to detect cases where the else branch contains the same expression as the if body, and transform to a single conditional. Look for any existing discussions or attempts (the issue is assigned but no PR). The maintainer might have input on desired approach. Focus on the AST patterns for the given example.