rust-lang/rust-clippy

Support for upcoming `param_attrs` feature

Open

#4,474 建立於 2019年8月30日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Rust (10,406 star) (1,391 fork)batch import
C-enhancementE-needs-testS-needs-discussiongood first issue

描述

param_attrs is likely to be stabilized in Rust 1.39

The param_attrs feature is going to allow lint attributes on function, method and closure parameters:

fn foo(
    a: i32,
    #[allow(unused_variables)] b: i32,
) {}

We should review how this feature ties in with our existing lints. Apparently it did not cause any toolstate breakage when it was merged.

Specifically, we should create a list of lints that could benefit from parameter attributes and then update those lints to make use of them (if that's even required).

貢獻者指南

技術棧
rust
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Understanding of Rust's param attrs featureFamiliarity with clippy's lint internals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
Review the linked Rust PR (https://github.com/rust lang/rust/pull/64010) to understand the param attrs feature. Then, examine clippy's existing lints to identify which ones could benefit from parameter attributes, such as those checking for unused parameters or style issues. Create a list of affected lints and update them to support the new attribute syntax if needed. No current comments or PRs provide further direction.
Support for upcoming `param_attrs` feature · rust-lang/rust-clippy#4474 | Good First Issue