rust-lang/rust-clippy

FR: redundant_field_names should distinguish between all and some fields matching

Open

#3,422 建立於 2018年11月10日

在 GitHub 查看
 (1 留言) (4 反應) (1 負責人)Rust (10,406 star) (1,391 fork)batch import
C-enhancementL-stylegood first issue

描述

redundant_field_names fires on any field being a match. This impairs readability in cases like this:

let thingy = Thingy {
   calc: big + calculation,
   redundant: redundant,
   other: stuff.into(),
};

As you can see, if you apply the suggestion, you end up with a weird line that is different from the rest. I suggest that the lint be split such that it distinguishes between "all fields are redundant" and "some fields are redundant".

貢獻者指南

技術棧
rust
領域
developer experiencetooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rust programmingClippy lint development basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Examine the existing `redundant field names` lint implementation in the clippy source code. The current behavior triggers when any field matches. To implement the distinction, modify the lint to check each field individually and categorize whether some or all fields are redundant. This likely involves iterating over the struct fields and comparing names. The lint is in `clippy lints/src/`; find the relevant file and understand how lints are structured. Consider adding a new variant to the diagnostic message or splitting the lint into two separate categories. Review any comments or discussions in the issue for additional context.