rust-lang/rust-clippy

`use_debug` lint should not trigger on `debug!()` log macro calls

Open

#2,132 建立於 2017年10月12日

在 GitHub 查看
 (7 留言) (1 反應) (0 負責人)Rust (10,406 star) (1,391 fork)batch import
C-enhancementT-middlegood first issue

描述

Example use-case:

#![cfg_attr(feature = "cargo-clippy", warn(use_debug))]

#[macro_use]
extern crate log;

pub fn euclid_steps(mut x: u64, mut y: u64) -> Vec<u64> {
    debug!("x = {}, y = {}", x, y);

    let mut steps = vec![];

    loop {
        let tmp = x % y;

        if tmp == 0 {
            debug!("Steps performed in Euclidean algorithm: {:?}", steps);
            return steps;
        }

        steps.push(tmp);
        x = y;
        y = tmp;
    }
}

Placing #![cfg_attr(feature = "cargo-clippy", allow(use_debug))] before each debug!() usage seems tedious to me when there are several dozens of them; and turning it off (even if locally) defeats the purpose of the lint.

貢獻者指南