rust-lang/rust-clippy

New lint: clone on arguments taken by reference

Open

#2,074 建立於 2017年9月19日

在 GitHub 查看
 (7 留言) (0 反應) (1 負責人)Rust (10,406 star) (1,391 fork)batch import
A-lintL-unnecessaryT-middlegood first issue

描述

If a function takes an argument by reference, but later calls .clone() on it (or otherwise requires an impl Clone or impl Copy from it), lint that taking it by ownership allows the caller to pass in its memory rather than forcing a clone on the data.

I don't know if this is possible, but can it default to allow on public functions and deny on crate-private functions (due to the API change)?

貢獻者指南

技術棧
rust
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rust programmingclippy internalsRust ownership model
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
To implement this lint, the contributor should first understand clippy's lint infrastructure by examining existing lints in the `clippy lints` crate. They should look at how other lints detect patterns in function signatures and bodies. The issue's comment thread may provide additional clarification. The functionality should detect functions that accept a reference and later call `.clone()` on it, and suggest changing to ownership. The distinction between public and crate private functions should be considered, possibly using the `is in unconfigured public` or similar attribute.
New lint: clone on arguments taken by reference · rust-lang/rust-clippy#2074 | Good First Issue