rust-lang/rust-clippy

Lint request: Prevent lifetimes that are only used for function output

Open

#1,874 建立於 2017年7月5日

在 GitHub 查看
 (9 留言) (0 反應) (0 負責人)Rust (10,406 star) (1,391 fork)batch import
A-lintL-correctnessS-needs-discussionT-middlegood first issue

描述

The following:

fn lifetime<'a>() -> &'a str {
    "Why some people do that"
}

Can be more clearly written as this. Also, using 'static lifetime makes it clear that it was intended, especially in unsafe code where returning unbound lifetime may as well be a mistake.

fn lifetime() -> &'static str {
    "Why some people do that"
}

貢獻者指南

技術棧
rust
領域
developer experiencetooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Rust language basicsUnderstanding of lifetimesFamiliarity with clippy's lint creation process
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue suggests a new lint to detect lifetimes that are only used in function outputs. Start by examining existing clippy lints related to lifetimes (e.g., in clippy lints/src/lifetimes.rs). Understand how clippy registers and implements lints. Look at the discussion in the issue comments for any additional constraints or alternatives. Consider the diagnostic output and potential false positives. Note that this is a feature request with no assignee, so it is available for contribution.