rust-lang/rust-clippy

Extensions to should_assert_eq

Open

#1,810 建立於 2017年6月3日

在 GitHub 查看
 (1 留言) (1 反應) (1 負責人)Rust (10,406 star) (1,391 fork)batch import
C-enhancementgood first issue

描述

I found this in the standard library:

assert!(o == owned && b == borrowed)

This should be a case for should_assert_eq. Additionally, it might be nice to have a lint that suggests splitting asserts with && to multiple assert statements, for better debugging.

貢獻者指南

技術棧
rust
領域
toolingdeveloper experiencetesting
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Rust programmingFamiliarity with clippy's lint systemBasic understanding of should assert eq
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
Investigate the current implementation of should assert eq in clippy, likely in the 'clippy lints' crate. The issue suggests modifying the lint to handle the pattern `assert!(o == owned && b == borrowed)` and possibly creating a new lint to split `&&` in assertions. Look at existing test files and the lint's documentation. Check if there are any previous attempts or related PRs by searching the issue tracker. The assignee may have left comments or a branch.