rust-lang/rust-clippy

Rewrite `arithmetic_side_effects` to not use matching on string representation of types

Open

#16,359 建立於 2026年1月8日

在 GitHub 查看
 (1 留言) (1 反應) (1 負責人)Rust (10,406 star) (1,391 fork)batch import
C-enhancementgood first issue

描述

Description

arithmetic_side_effects uses the string representation of types to compare them. This will miss aliases (including core/alloc → std), takes longer to compare, etc.

It should use a method similar to what is done in the disallowed_types lint, where maps of DefId or PrimTy are built at lint initialization time and then used throughout the tree walk. Some type lookup code could probably even be shared (including the part where unloaded crates don't cause errors).

Version

Additional Labels

No response

貢獻者指南

技術棧
rust
領域
developer experiencetooling
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
RustClippy internalsDefId and PrimTyLint initialization
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Study the implementation of the `disallowed types` lint in the clippy codebase to understand how maps of DefId or PrimTy are built at initialization. Look at files like `clippy lints/src/disallowed types.rs` and the associated type lookup code. The goal is to replicate that pattern in `arithmetic side effects` located in `clippy lints/src/arithmetic side effects.rs`. Ensure that the new approach handles type aliases and avoids string representation comparisons.
Rewrite `arithmetic_side_effects` to not use matching on string representation of types · rust-lang/rust-clippy#16359 | Good First Issue