rust-lang/rust-clippy

Always true expressions in if expressions

Open

#1,593 建立於 2017年3月3日

在 GitHub 查看
 (3 留言) (0 反應) (1 負責人)Rust (10,406 star) (1,391 fork)batch import
A-lintL-correctnessT-middlegood first issue

描述

I'd like Clippy to find this problem in the code, this expression is always true, and Clippy should also suggest the usage of && here instead:

fn foo1a(name: &str) {
    if name != "Min" || name != "Max" {}
}

Another example:

fn foo1b(x: i32) -> bool {
    x > 10 || x < 25
}

貢獻者指南

技術棧
rust
領域
tooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rust programmingClippy lint developmentAST basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The issue requests a new lint to detect always true expressions like `name != "Min" || name != "Max"`. The issue is assigned to Dominic Moser. To implement, you'd need to understand Clippy's lint structure, likely adding a new lint in the `clippy lints` crate. The examples are clear, but ensure the lint doesn't produce false positives. Check existing lints like `if not else` for patterns. No linked PRs or additional comments provide further guidance.